Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: docs for dwh cost estimates and savings #3554

Merged
merged 2 commits into from
Jan 13, 2025
Merged

docs: docs for dwh cost estimates and savings #3554

merged 2 commits into from
Jan 13, 2025

Conversation

caiters
Copy link
Contributor

@caiters caiters commented Dec 21, 2024

No description provided.

treysp
treysp reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@treysp treysp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Made a PR against this branch so you can see my edits. #3564

@treysp treysp force-pushed the docs/costs-savings branch from 3312fb8 to ee8a5b8 Compare January 6, 2025 21:39
sungchun12
sungchun12 requested changes Jan 7, 2025
View reviewed changes
docs/cloud/features/costs_savings.md Outdated Show resolved Hide resolved
docs/cloud/features/costs_savings.md Outdated Show resolved Hide resolved
docs/cloud/features/costs_savings.md Show resolved Hide resolved
docs/cloud/features/costs_savings.md Show resolved Hide resolved
docs/cloud/features/costs_savings.md Outdated Show resolved Hide resolved
@caiters caiters requested a review from sungchun12 January 9, 2025 20:04
crericha
crericha reviewed Jan 9, 2025
View reviewed changes
docs/cloud/features/costs_savings.md Outdated

### Where to find cost savings information

Cost savings are shown in most of the places data warehouse costs are displayed. You can find how much Tobiko Cloud has saved you by viewing the homepage, production environment page, or individual model pages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not show on the plan page yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct - I think we had wanted to be conservative with where we display aggregated costs, so those only live on the listed pages. The Plan page only has costs listed by execution in the model executions table, and we haven't added savings as a column there yet

@treysp treysp force-pushed the docs/costs-savings branch from 735ce73 to 6cc0b36 Compare January 13, 2025 22:31
@treysp treysp self-requested a review January 13, 2025 22:52
@caiters caiters merged commit b04cc4b into main Jan 13, 2025
21 checks passed
@caiters caiters deleted the docs/costs-savings branch January 13, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crericha crericha crericha left review comments

@sungchun12 sungchun12 sungchun12 approved these changes

@treysp treysp treysp approved these changes

@mesmith027 mesmith027 Awaiting requested review from mesmith027

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caiters @treysp @sungchun12 @crericha